distributor: allow skipping label count validation #9576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ortuman
changed the title
(*WriteRequest).SkipLabelCountValidation field
ortuman
force-pushed
the
ortuman/allow-skipping-label-count-validation
branch
6 times, most recently
from
889afb6
to
23e4d0b
Compare
tacole02
approved these changes
Oct 10, 2024
replay
reviewed
Oct 11, 2024
replay
reviewed
Oct 11, 2024
Signed-off-by: Miguel Ángel Ortuño <[email protected]>
Signed-off-by: Miguel Ángel Ortuño <[email protected]>
Signed-off-by: Miguel Ángel Ortuño <[email protected]>
Signed-off-by: Miguel Ángel Ortuño <[email protected]>
Signed-off-by: Miguel Ángel Ortuño <[email protected]>
Signed-off-by: Miguel Ángel Ortuño <[email protected]>
Signed-off-by: Miguel Ángel Ortuño <[email protected]>
Co-authored-by: Taylor C <[email protected]>
Co-authored-by: Taylor C <[email protected]>
Co-authored-by: Mauro Stettler <[email protected]>
Signed-off-by: Miguel Ángel Ortuño <[email protected]>
ortuman
force-pushed
the
ortuman/allow-skipping-label-count-validation
branch
from
94d04e6
to
21bda1d
Compare
Signed-off-by: Miguel Ángel Ortuño <[email protected]>
Signed-off-by: Miguel Ángel Ortuño <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR introduces a new feature that enables users to bypass label count validation via the
X-Mimir-SkipLabelCountValidationheader.A new configuration option,
-api.skip-label-count-validation-header-enabledhas been added to control this behavior. If enabled, users can set the header totrueto skip label count validation.In principle, this feature is not intended to be used by Mimir itself, but rather by projects that depend on it.
Which issue(s) this PR fixes or relates to
Fixes n/a
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.