Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #9511 #9566

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Revert #9511 #9566

merged 1 commit into from
Oct 8, 2024

Conversation

gotjosh
Copy link
Contributor

@gotjosh gotjosh commented Oct 8, 2024

This reverts #9511 as it panics ingesters.

The details are:

│ panic: runtime error: invalid memory address or nil pointer dereference                                                                                                                      │
│     panic: runtime error: invalid memory address or nil pointer dereference                                                                                                                  │
│ [signal SIGSEGV: segmentation violation code=0x1 addr=0x30 pc=0x13b2350]                                                                                                                     │

     $GOROOT/src/runtime/panic.go:785 +0x124                                                                                                                                                  │
│ github.com/twmb/franz-go/pkg/kgo/internal/pool.(*BucketedPool[...]).Get(0x0?, 0x0?)

This reverts #9511 as it panics ingesters.

The details are:

```
│ panic: runtime error: invalid memory address or nil pointer dereference                                                                                                                      │
│     panic: runtime error: invalid memory address or nil pointer dereference                                                                                                                  │
│ [signal SIGSEGV: segmentation violation code=0x1 addr=0x30 pc=0x13b2350]                                                                                                                     │

     $GOROOT/src/runtime/panic.go:785 +0x124                                                                                                                                                  │
│ github.com/twmb/franz-go/pkg/kgo/internal/pool.(*BucketedPool[...]).Get(0x0?, 0x0?)
```

Signed-off-by: gotjosh <[email protected]>
@gotjosh gotjosh merged commit ab3e627 into main Oct 8, 2024
29 checks passed
@gotjosh gotjosh deleted the revert-pr-9511 branch October 8, 2024 15:55
@grafanabot
Copy link
Contributor

The backport to r311 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-9566-to-r311 origin/r311
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x ab3e627b1da134f33c06dd09ee4402a2eaad68f1
# Push it to GitHub
git push --set-upstream origin backport-9566-to-r311
git switch main
# Remove the local backport branch
git branch -D backport-9566-to-r311

Then, create a pull request where the base branch is r311 and the compare/head branch is backport-9566-to-r311.

gotjosh added a commit that referenced this pull request Oct 8, 2024
This reverts #9511 as it panics ingesters.

The details are:

```
│ panic: runtime error: invalid memory address or nil pointer dereference                                                                                                                      │
│     panic: runtime error: invalid memory address or nil pointer dereference                                                                                                                  │
│ [signal SIGSEGV: segmentation violation code=0x1 addr=0x30 pc=0x13b2350]                                                                                                                     │

     $GOROOT/src/runtime/panic.go:785 +0x124                                                                                                                                                  │
│ github.com/twmb/franz-go/pkg/kgo/internal/pool.(*BucketedPool[...]).Get(0x0?, 0x0?)
```

Signed-off-by: gotjosh <[email protected]>
(cherry picked from commit ab3e627)
@gotjosh gotjosh mentioned this pull request Oct 8, 2024
gotjosh added a commit that referenced this pull request Oct 8, 2024
This reverts #9511 as it panics ingesters.

The details are:

```
│ panic: runtime error: invalid memory address or nil pointer dereference                                                                                                                      │
│     panic: runtime error: invalid memory address or nil pointer dereference                                                                                                                  │
│ [signal SIGSEGV: segmentation violation code=0x1 addr=0x30 pc=0x13b2350]                                                                                                                     │

     $GOROOT/src/runtime/panic.go:785 +0x124                                                                                                                                                  │
│ github.com/twmb/franz-go/pkg/kgo/internal/pool.(*BucketedPool[...]).Get(0x0?, 0x0?)
```

Signed-off-by: gotjosh <[email protected]>
(cherry picked from commit ab3e627)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants