Chore: Automate helm test/doc update for renovate PR #6270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pstibrany
reviewed
Oct 6, 2023
ying-jeanne
force-pushed
the
renovatefixlint
branch
from
b0722cf
to
8ab651f
Compare
|
Building new version of mimir-build-image. After image is built and pushed to Docker Hub, a new commit will automatically be added to this PR with new image version `grafana/mimir-build-image:pr6270-409ec28ca6`. This can take up to 1 hour. |
|
The installation is not straight forward, and I am getting the same error as here cli/cli#1797, plan to fix the renovate build for now. getting this improvement of using gh from build image in a separate PR to keep the changes small. |
ying-jeanne
force-pushed
the
renovatefixlint
branch
from
29ee863
to
5f5cb96
Compare
ying-jeanne
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
When we update dependency like minio ying-jeanne#43, we need to update helm test equally in order to make ci passes, this PR is to add a script run after each renovate PR, update helm tests when necessary.
See test on my personal fork https://github.com/ying-jeanne/mimir/pull/43/commits
If you see some part seems "wierd", it is mainly because of using container in github action is tricky.
Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]