Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm: add Troubleshoot section to kubernetes 1.25 migration guide #5483

Merged

Conversation

krajorama
Copy link
Contributor

@krajorama krajorama commented Jul 12, 2023

Related to #5357

@krajorama krajorama requested review from a team as code owners July 12, 2023 11:03
@krajorama krajorama added the helm label Jul 12, 2023
```

1. Optionally follow the Kubernetes [Migrate from PodSecurityPolicy to the Built-In PodSecurity Admission Controller](https://kubernetes.io/docs/tasks/configure-pod-container/migrate-from-psp/) guide to replace PodSecurityPolicy.
1. Set the `rbac.create` value to `false`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That shouldn't be necessary because the chart already doesn't render it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this way you can reuse this doc on older chart versions!

krajorama and others added 2 commits July 12, 2023 13:15
Co-authored-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: György Krajcsovits <[email protected]>
Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@dimitarvdimitrov dimitarvdimitrov merged commit fd34a5e into mimir-distributed-release-5.0 Jul 12, 2023
28 checks passed
@dimitarvdimitrov dimitarvdimitrov deleted the krajo/helm-psp-fix-doc branch July 12, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants