Add query results cache support for label names and label values APIs #5426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
pracucci
force-pushed
the
add-query-results-cache-support-for-label-apis
branch
from
18bcd0d
to
70ba7f4
Compare
pracucci
changed the title
Signed-off-by: Marco Pracucci <[email protected]>
pracucci
force-pushed
the
add-query-results-cache-support-for-label-apis
branch
from
70ba7f4
to
9c23199
Compare
Signed-off-by: Marco Pracucci <[email protected]>
pracucci
commented
Jul 6, 2023
| instantQueryPathSuffix = "/query" | ||
| cardinalityLabelNamesPathSuffix = "/cardinality/label_names" | ||
| cardinalityLabelValuesPathSuffix = "/cardinality/label_values" | ||
| queryRangePathSuffix = "/api/v1/query_range" |
There was a problem hiding this comment.
Note to reviwers: adding the /api/v1/ prefix is not expected to be a breaking change because these are the prefixes mapped in pkg/api/api.go.
Signed-off-by: Marco Pracucci <[email protected]>
dimitarvdimitrov
approved these changes
Jul 6, 2023
Signed-off-by: Marco Pracucci <[email protected]>
Signed-off-by: Marco Pracucci <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Similarly to #5212, in this PR I'm adding the support to cache label names and label values responses. See details at: #5395
Note to reviewers:
Which issue(s) this PR fixes or relates to
Fixes #5395
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]