fix(rw2.0): reject remote write 2.0 based on content type #10423
+84
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With this patch, Prometheus gets: |
The current solution returns 2xx , but doesn't actually ingest the samples. Prometheus does detect this prometheus-1 | time=2025-01-13T13:01:35.028Z level=ERROR source=queue_manager.go:1670 msg="non-recoverable error" component=remote remote_name=150c10 url=http://mimir-1:8001/api/v1/push failedSampleCount=2000 failedHistogramCount=0 failedExemplarCount=0 err="sent v2 request with 2000 samples, 0 histograms and 0 exemplars; got 2xx, but PRW 2.0 response header statistics indicate 0 samples, 0 histograms and 0 exemplars were accepted; assumining failure e.g. the target only supports PRW 1.0 prometheus.WriteRequest, but does not check the Content-Type header correctly" But we can do better and also start working towards RW2.0 support. Signed-off-by: György Krajcsovits <[email protected]>
krajorama
force-pushed
the
feat/remote-write-two
branch
from
70ef976 to
5dd0ff1
Compare
NickAnge
reviewed
Jan 13, 2025
| @@ -29,6 +29,7 @@ | |||
| * [BUGFIX] MQE: Fix deriv with histograms #10383 | |||
| * [BUGFIX] PromQL: Fix <aggr_over_time> functions with histograms https://github.com/prometheus/prometheus/pull/15711 #10400 | |||
| * [BUGFIX] MQE: Fix <aggr_over_time> functions with histograms #10400 | |||
| * [BUGFIX] Distributor: return HTTP status 415 Unsupported medica type instead of success for Remote Write 2.0 until we support it. #10423 | |||
There was a problem hiding this comment.
Suggested change
| * [BUGFIX] Distributor: return HTTP status 415 Unsupported medica type instead of success for Remote Write 2.0 until we support it. #10423 | |
| * [BUGFIX] Distributor: return HTTP status 415 Unsupported Media Type instead of success for Remote Write 2.0 until we support it. #10423 |
Not sure if we want lower case though
There was a problem hiding this comment.
Really good catch, @NickAnge . According to the Google Developer Documentation Style Guide, it should be capitalized and monospace, i.e.: 415 Unsupported Media Type
There was a problem hiding this comment.
We should follow the same format for the 200 Success status for the sake of consistency.
tacole02
approved these changes
Jan 13, 2025
| @@ -29,6 +29,7 @@ | |||
| * [BUGFIX] MQE: Fix deriv with histograms #10383 | |||
| * [BUGFIX] PromQL: Fix <aggr_over_time> functions with histograms https://github.com/prometheus/prometheus/pull/15711 #10400 | |||
| * [BUGFIX] MQE: Fix <aggr_over_time> functions with histograms #10400 | |||
| * [BUGFIX] Distributor: return HTTP status 415 Unsupported medica type instead of success for Remote Write 2.0 until we support it. #10423 | |||
There was a problem hiding this comment.
Really good catch, @NickAnge . According to the Google Developer Documentation Style Guide, it should be capitalized and monospace, i.e.: 415 Unsupported Media Type
| @@ -29,6 +29,7 @@ | |||
| * [BUGFIX] MQE: Fix deriv with histograms #10383 | |||
| * [BUGFIX] PromQL: Fix <aggr_over_time> functions with histograms https://github.com/prometheus/prometheus/pull/15711 #10400 | |||
| * [BUGFIX] MQE: Fix <aggr_over_time> functions with histograms #10400 | |||
| * [BUGFIX] Distributor: return HTTP status 415 Unsupported medica type instead of success for Remote Write 2.0 until we support it. #10423 | |||
There was a problem hiding this comment.
We should follow the same format for the 200 Success status for the sake of consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Reject remote write 2.0 request properly with HTTP status 415, based on RW2.0 spec.
The current solution returns 2xx , but doesn't actually ingest the samples.
Prometheus does detect this
prometheus-1 | time=2025-01-13T13:01:35.028Z level=ERROR source=queue_manager.go:1670 msg="non-recoverable error" component=remote remote_name=150c10
url=http://mimir-1:8001/api/v1/push failedSampleCount=2000
failedHistogramCount=0 failedExemplarCount=0
err="sent v2 request with 2000 samples, 0 histograms and 0 exemplars;
got 2xx, but PRW 2.0 response header statistics indicate 0 samples,
0 histograms and 0 exemplars were accepted; assumining failure e.g.
the target only supports PRW 1.0 prometheus.WriteRequest, but does not
check the Content-Type header correctly"
But we can do better and also start working towards RW2.0 support.
Which issue(s) this PR fixes or relates to
Related to #9072
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.