Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: wire up ingest-limits service #16660

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: wire up ingest-limits service #16660

wants to merge 5 commits into from
+704 −0

Conversation

grobinson-grafana
Copy link
Contributor

@grobinson-grafana grobinson-grafana commented Mar 10, 2025 •
edited
Loading

What this PR does / why we need it:

This pull request wires up the ingest-limits service.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@grobinson-grafana grobinson-grafana requested a review from a team as a code owner March 10, 2025 10:02
@grobinson-grafana
Copy link
Contributor Author

Needs a PR from @periklis to update the distributor, then we can rebase and CI should pass.

@grobinson-grafana grobinson-grafana force-pushed the grobinson/wire-up-ingest-limits branch 2 times, most recently from 8372f76 to 8f220a3 Compare March 10, 2025 15:12
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Mar 10, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 10, 2025 •
edited
Loading

💻 Deploy preview available:

@grobinson-grafana grobinson-grafana force-pushed the grobinson/wire-up-ingest-limits branch from 8f220a3 to 3e05194 Compare March 10, 2025 15:20
@grobinson-grafana grobinson-grafana force-pushed the grobinson/wire-up-ingest-limits branch from 3e05194 to 8e79722 Compare March 10, 2025 15:37
periklis
periklis approved these changes Mar 11, 2025
View reviewed changes
Copy link
Collaborator

@periklis periklis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks overall good to me.

@grobinson-grafana grobinson-grafana force-pushed the grobinson/wire-up-ingest-limits branch from e0d675c to 50c7e3e Compare March 11, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@periklis periklis periklis approved these changes

Assignees
No one assigned
Labels
size/XL type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grobinson-grafana @periklis