Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Update openshift service address in grafana connection examples #16113

Conversation

coffeegoesincodecomesout
Copy link

@coffeegoesincodecomesout coffeegoesincodecomesout commented Feb 5, 2025

What this PR does / why we need it:

Updates the openshift operator service address in the examples provided.
Users are opening cases against the Red Hat support desk reporting that this integration does not work.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Hello Robert ::waves::
Hello Periklis ::waves::

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@CLAassistant
Copy link

CLAassistant commented Feb 5, 2025

CLA assistant check
All committers have signed the CLA.

@coffeegoesincodecomesout coffeegoesincodecomesout changed the title Update openshift service address Fix: Update openshift service address Feb 5, 2025
@coffeegoesincodecomesout coffeegoesincodecomesout changed the title Fix: Update openshift service address Fix: Update openshift service address in grafana connection examples Feb 5, 2025
@r2d2rnd
Copy link

r2d2rnd commented Feb 7, 2025

The Lokistack Gateway is formed depending on the name given to the Lokistack CR that it must not needed an static fixed and it's changed and used different values.

It's true that in the Red Hat OpenShift docs is now logging-loki, but it's only a value given as example that can take any desired value by an user. Then, if it's needed to change something, it should be to explain how to get the LokiStack Gateway URL independent of the LokiStack CR name.

@coffeegoesincodecomesout
Copy link
Author

@r2d2rnd Then perhaps the docs hosted here should point that out - and provide a command to extract it.
Otherwise "We" - RedHat are pointing users at upstream docs that dont work for our users and are generating support cases

Otherwise "We" - RedHat need to maintain docs for things we dont support

@xperimental xperimental self-assigned this Feb 7, 2025
@JStickler
Copy link
Contributor

@r2d2rnd Then perhaps the docs hosted here should point that out - and provide a command to extract it.
Otherwise "We" - RedHat are pointing users at upstream docs that dont work for our users and are generating support cases
Otherwise "We" - RedHat need to maintain docs for things we dont support

FYI @coffeegoesincodecomesout, the vast majority of the code in the /operator/ directory was written by Red Hat engineers. I know this as a recent member of the Red Hat OpenShift docs team, and a current member of the Grafana Labs Loki team. So while it's upstream, the Loki Operator is Red Hat's work.

@xperimental
Copy link
Collaborator

@JStickler Thanks for the help and sorry for the confusion.

I was out sick last week and while I had quickly talked about this issue directly with @coffeegoesincodecomesout I did not comment on here. (both @coffeegoesincodecomesout and @r2d2rnd are from Red Hat as well)

The conclusion was that the examples in this repo are currently mostly geared towards development and will stay that way, at least for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants