-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: helm thanos support #16110
Merged
Merged
chore: helm thanos support #16110
+231
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
💻 Deploy preview deleted. |
fcjack
commented
Feb 5, 2025
This comment has been minimized.
This comment has been minimized.
ashwanthgoli
reviewed
Feb 6, 2025
ashwanthgoli
reviewed
Feb 6, 2025
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
0c4a6ef
to
b6c5b6c
Compare
ashwanthgoli
reviewed
Feb 6, 2025
This comment has been minimized.
This comment has been minimized.
ashwanthgoli
approved these changes
Feb 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. left a couple of nits
Helm Diff Output - SummarySingle Binary ScenarioDefault Values ScenarioIngress Values ScenarioLegacy Monitoring ScenarioSimple Scalable AWS Kube IRSA ScenarioSimple Thanos Scenario520d519
< prefix: null
522,531c521
< access_key_id: thanos-minio
< bucket_name: admin_thanos
< endpoint: http://minio.minio.svc.cluster.local:9000
< http:
< tls_config:
< insecure_skip_verify: true
< insecure: true
< region: us-east-1
< secret_access_key: thanos-minio123
< sse: {}
---
> bucket_name: admin
564,576c554,560
< object_store:
< prefix: null
< s3:
< access_key_id: thanos-minio
< bucket_name: chunks_thanos
< endpoint: http://minio.minio.svc.cluster.local:9000
< http:
< tls_config:
< insecure_skip_verify: true
< insecure: true
< region: us-east-1
< secret_access_key: thanos-minio123
< sse: {}
---
> s3:
> access_key_id: root-user
> bucketnames: chunks
> endpoint: loki-release-minio.default.svc:9000
> insecure: true
> s3forcepathstyle: true
> secret_access_key: supersecretpassword
620,633d603
< ruler_storage:
< backend: s3
< prefix: null
< s3:
< access_key_id: thanos-minio
< bucket_name: ruler_thanos
< endpoint: http://minio.minio.svc.cluster.local:9000
< http:
< tls_config:
< insecure_skip_verify: true
< insecure: true
< region: us-east-1
< secret_access_key: thanos-minio123
< sse: {}
1271c1241
< checksum/config: 1c596ed8933ceee9bd7c5e30b7b4b6b7c8060ceb4c345db76938b297f96a59e4
---
> checksum/config: 0afeeec017d60fd5bb2d0c8900214e5cdaa121f2c08993d250c03f0821c0d22e
1377c1347
< checksum/config: 1c596ed8933ceee9bd7c5e30b7b4b6b7c8060ceb4c345db76938b297f96a59e4
---
> checksum/config: 0afeeec017d60fd5bb2d0c8900214e5cdaa121f2c08993d250c03f0821c0d22e
1481c1451
< checksum/config: 1c596ed8933ceee9bd7c5e30b7b4b6b7c8060ceb4c345db76938b297f96a59e4
---
> checksum/config: 0afeeec017d60fd5bb2d0c8900214e5cdaa121f2c08993d250c03f0821c0d22e
1697c1667
< checksum/config: 1c596ed8933ceee9bd7c5e30b7b4b6b7c8060ceb4c345db76938b297f96a59e4
---
> checksum/config: 0afeeec017d60fd5bb2d0c8900214e5cdaa121f2c08993d250c03f0821c0d22e
2054c2024
< checksum/config: 1c596ed8933ceee9bd7c5e30b7b4b6b7c8060ceb4c345db76938b297f96a59e4
---
> checksum/config: 0afeeec017d60fd5bb2d0c8900214e5cdaa121f2c08993d250c03f0821c0d22e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We are adding the support to thanos storage config inside our helm chart.
Together with this we are doing some refactor in our helpers to make our chart more reusable in some components and avoid code duplication.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
deprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR