feat: Introduce policy stream mapping #15982
Open
+216
−83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…na/loki into retention-as-label-when-discarding
DylanGuedes
changed the base branch from
main
to
retention-as-label-when-discarding
DylanGuedes
force-pushed
the
add-stream-mapping-to-loki
branch
from
87272ca to
243f34e
Compare
…na/loki into add-stream-mapping-to-loki
github-actions
bot
added
the
type/docs
|
💻 Deploy preview available: https://deploy-preview-loki-15982-zb444pucvq-vp.a.run.app/docs/loki/latest/ |
JStickler
reviewed
Jan 29, 2025
| @@ -3927,6 +3927,9 @@ otlp_config: | |||
| # CLI flag: -validation.enforced-labels | |||
| [enforced_labels: <list of strings> | default = []] | |||
|
|
|||
| # Map of policies to stream selectors with a priority. Experimental. | |||
There was a problem hiding this comment.
Is there a default for this setting? (even if the default is nothing is set?)
Also, this could use an example in the description, since users might not know what a mapping should look like.
There was a problem hiding this comment.
No, default means no mapping and no policies assigned.
But good call, I'll improve the docs of this struct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Introduces the idea of policies to Loki, which are recognizable based on the given stream selectors.
This is an improved version of #15561 and built on top of #15875.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR