Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing routes for rules api to gateway #15825

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: add missing routes for rules api to gateway #15825

wants to merge 1 commit into from

Conversation

martipoe
Copy link

@martipoe martipoe commented Jan 17, 2025 •
edited
Loading

What this PR does / why we need it:
Resolves the error message "Failed to load the data source configuration for Loki: Unable to fetch alert rules. Is the Loki data source properly configured?" for alert and recording rules in Grafana Alert Overview of docker-compose stack.

df951fdf41ff90791d94d56aac43d9c9457fd066_2_690x167

Which issue(s) this PR fixes:
Fixes #42963 via grafana/grafana#42963 (comment)

Special notes for your reviewer:
Adds a route to the backend, which runs the ruler.

Checklist

  • [ x] Reviewed the CONTRIBUTING.md guide (required)
  • [x ] Documentation added
  • [ x] Tests updated
  • [ x] Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • [x ] Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • [x ] If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@martipoe martipoe requested a review from a team as a code owner January 17, 2025 17:19
@CLAassistant
Copy link

CLAassistant commented Jan 17, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@martipoe martipoe marked this pull request as draft January 17, 2025 17:20
@martipoe martipoe closed this Jan 17, 2025
@martipoe
fix: missing route to prometheus api endpoint via backend in docker-c…
26911fa 
…ompose setup

Resolves the error message "Failed to load the data source configuration for Loki: Unable to fetch alert rules. Is the Loki data source properly configured?" for alert and recording rules in Grafana Alert Overview of docker-compose stack.

Signed-off-by: martipoe <[email protected]>
@martipoe martipoe reopened this Jan 17, 2025
@martipoe martipoe marked this pull request as ready for review January 17, 2025 17:35
@martipoe martipoe changed the title fix: missing route to prometheus api endpoint via backend in docker-compose setup fix: missing route to rule api via backend in docker-compose setup Jan 17, 2025
@martipoe martipoe changed the title fix: missing route to rule api via backend in docker-compose setup fix: add missing routes for rules api to gateway Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martipoe @CLAassistant