Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dataobj): fix dataobj_config metrics #15824

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

rfratto
Copy link
Member

@rfratto rfratto commented Jan 17, 2025

The config metrics weren't registered, but you also can't register constant metrics so I needed to switch them over to a gauge.

@rfratto rfratto requested a review from a team as a code owner January 17, 2025 16:19
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rfratto rfratto merged commit 9be1474 into grafana:main Jan 17, 2025
61 checks passed
@rfratto rfratto deleted the fix-dataobj-config-metrics branch January 17, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants