chore(dataobj): add streams tracking and encoding #15713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces the streams package, which tracks a list of streams in a data object. Each stream is given an ID unique to the scope of a data object. This allows for streams to eventually be split up across multiple sections if one section becomes too large.
rfratto
force-pushed
the
dataobj-streams
branch
from
b2b8774 to
538768e
Compare
benclive
reviewed
Jan 14, 2025
This will help callers chain the result of recording a stream to then populating it in the future logs section.
benclive
approved these changes
Jan 14, 2025
rfratto
added a commit
to rfratto/loki
that referenced
this pull request
Jan 14, 2025
This commit is the equivalent of grafana#15713 for the logs section: log records are accumulated into column builders and then flushed into a section at encoding time. Some minor API changes have been made to sections/streams to ensure consistency with sections/logs.
rfratto
added a commit
to rfratto/loki
that referenced
this pull request
Jan 14, 2025
This commit is the equivalent of grafana#15713 for the logs section: log records are accumulated into column builders and then flushed into a section at encoding time. Some minor API changes have been made to sections/streams to ensure consistency with sections/logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces the streams package, which tracks a list of streams in a data object.
Each stream is given an ID unique to the scope of a data object. This allows for streams to eventually be split up across multiple sections if one section becomes too large.