-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(loki): add support for sts endpoint when using s3 buckets #13518
base: main
Are you sure you want to change the base?
Conversation
Tiago Posse seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
@tiagoposse Have you considered already incoming work like this that might fit your purpose: In general @JoaoBraveCoding is contributing the full switch for all clients to use thanos-objstore, e.g. GCP, Azure, Swift. This is a general course we follow on among the maintainers team. |
@periklis the linked PR indeed overwrites the changes I introduce here and it's definitely the correct way to go. My problem is that this PR is open for a considerable time and is quite a high impact change, so it will likely take a while to get merged. |
The PR has been quite long open because we postponed it after 3.x. However we are here at good path to this merged soon, @kavirajk and @JoaoBraveCoding work in that regard closely. |
What this PR does / why we need it:
This PR introduces the ability to override the sts endpoint used to authenticate with the AWS sdk / thanos s3 provider. It also provides a path to use STS authentication with minio operator.
As a note for those who try the minio operator STS auth: the AWS SDK adds a trailing slash when calling STS endpoint, which will cause the auth call to fail with 404. An nginx proxy can fix this the following config:
Which issue(s) this PR fixes:
Fixes #10751
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (required)
feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR