Use TSDB index prefix on blooms directory #11977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaudum
reviewed
Feb 16, 2024
| tenant string, | ||
| ownershipRange v1.FingerprintBounds, | ||
| ) error { | ||
| logger := log.With(s.logger, "ownership", ownershipRange, "org_id", tenant, "table", table) |
There was a problem hiding this comment.
You can change the signature to accept the struct, not a pointer.
There was a problem hiding this comment.
I don't think we need to log the full table name, the day is probably more convenient.
There was a problem hiding this comment.
I'd say seeing the full table name is clearer wrt which TSDB table are we working with (and where will we write to)
chaudum
reviewed
Feb 16, 2024
chaudum
approved these changes
Feb 16, 2024
chaudum
added a commit
that referenced
this pull request
Feb 21, 2024
The support for table prefixes was introduced with #11977 Signed-off-by: Christian Haudum <[email protected]>
rhnasc
pushed a commit
to inloco/loki
that referenced
this pull request
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Before this PR, bloom blocks and metas were written to
bloom/<day>/<tenant>..., but the gateway expects it to be atbloom/<index prefix>_<day>/<tenant>. This PR adds the index prefix to the path.Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)CHANGELOG.mdupdatedadd-to-release-noteslabeldocs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR