Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Blooms) Add metrics to compactor #11966

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Conversation

salvacorts
Copy link
Contributor

What this PR does / why we need it:
This PR adds new metrics to the bloom-compactor:

  • loki_bloomcompactor_compactions_started: Total number of compactions started
  • loki_bloomcompactor_compactions_completed: Total number of compactions completed. With status (success, failure).
  • loki_bloomcompactor_compactions_time_seconds: Time spent during a compaction cycle. With status (success, failure).
  • loki_bloomcompactor_tenants_discovered: Number of tenants discovered during the current compaction run.
  • loki_bloomcompactor_tenants_skipped: Number of tenants owned by this instance.
  • loki_bloomcompactor_tenants_skipped: Number of tenants skipped since they are not owned by this instance.
  • loki_bloomcompactor_tenants_started: Number of tenants started to process during the current compaction run.
  • loki_bloomcompactor_tenants_completed: Number of tenants successfully processed during the current compaction run. With status (success, failure).
  • loki_bloomcompactor_tenants_time_seconds: Time spent processing tenants.
  • loki_bloomcompactor_tenants_series: Number of series processed per tenant in the owned fingerprint-range.

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@salvacorts salvacorts force-pushed the salvacorts/bloom-compactor-metrics branch from 9284c4f to fac9c98 Compare February 15, 2024 15:01
@salvacorts salvacorts force-pushed the salvacorts/bloom-compactor-metrics branch from fac9c98 to 7845f00 Compare February 15, 2024 15:28
@salvacorts salvacorts marked this pull request as ready for review February 15, 2024 15:28
@salvacorts salvacorts requested a review from a team as a code owner February 15, 2024 15:28
@owen-d owen-d merged commit 543aaab into main Feb 15, 2024
8 checks passed
@owen-d owen-d deleted the salvacorts/bloom-compactor-metrics branch February 15, 2024 19:21
rhnasc pushed a commit to inloco/loki that referenced this pull request Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants