Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm: Add alibabacloud to isUsingObjectStorage. #11946

Merged
merged 7 commits into from
Feb 19, 2024

Conversation

lindeskar
Copy link
Contributor

@lindeskar lindeskar commented Feb 14, 2024

What this PR does / why we need it:
Allow setting alibabacloud in .Values.loki.storage.type.

Which issue(s) this PR fixes:
Fixes #11945

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

Sorry, something went wrong.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@CLAassistant
Copy link

CLAassistant commented Feb 14, 2024

CLA assistant check
All committers have signed the CLA.

@lindeskar lindeskar changed the title Helm: add alibabacloud to isUsingObjectStorage Helm: Add alibabacloud to isUsingObjectStorage Feb 14, 2024
@lindeskar lindeskar changed the title Helm: Add alibabacloud to isUsingObjectStorage Helm: Add alibabacloud to isUsingObjectStorage. Feb 14, 2024
@lindeskar lindeskar marked this pull request as ready for review February 14, 2024 14:52
@lindeskar lindeskar requested a review from a team as a code owner February 14, 2024 14:52
@MichelHollands
Copy link
Contributor

@lindeskar Thanks for your contribution, Can you update the version in all the places mentioned in the Helm chart checklist item? Once that is done I'll merge it (if there are no other issues).

MichelHollands and others added 2 commits February 16, 2024 16:33
@lindeskar
Copy link
Contributor Author

I thought I had. 😄 Fixed now!
Let me know if something else is missing.

Copy link
Contributor

@MichelHollands MichelHollands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichelHollands MichelHollands merged commit 50b51dd into grafana:main Feb 19, 2024
10 checks passed
rhnasc pushed a commit to inloco/loki that referenced this pull request Apr 12, 2024
mraboosk pushed a commit to mraboosk/loki that referenced this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Helm] alibabacloud storage type is not supported
3 participants