feat: add distributed mode to loki helm chart #11842
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What this PR does / why we need it**: Components were expecting the port name to be `http` instead of `http-metrics`. **Which issue(s) this PR fixes**: N/A
**What this PR does / why we need it**: Modify our nginx proxy pass to redirect to microservices components correctly. Modify index-gateway to run in simple mode by default. Fix distributor svc target port (http-metrics instead of `http`). **Which issue(s) this PR fixes**: N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds a distributed mode to the official Loki helm chart, largely taken from
loki-distributed. At this point all the pods come up, but I doubt it's actually ingesting/querying logs successfully. However, I wanted to get it up so we can start collaborating and moving forward on this.Note, if we merge this, it may block our ability to bump the helm version for a bit as we'd want to make sure it actually works before doing so, as that will "release" it. I think that's probably a worthwhile trade-off as many in the community have asked for this functionality, but we should probably at least make sure it's ingesting/querying correctly before merging.
This PR adds a new
k3denv which can be spun up withmake loki-distributedin thetools/dev/k3dfolder so we can test it locally.