Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a test to show how to use the clusterMetrics feature support the CoreDNS service integration #1229

Merged
merged 6 commits into from
Feb 12, 2025

Conversation

petewall
Copy link
Collaborator

No description provided.

… CoreDNS service integration

Signed-off-by: Pete Wall <[email protected]>
@petewall petewall force-pushed the feat/coredns-integration branch from a9a511a to efafa74 Compare February 12, 2025 16:02
@petewall petewall marked this pull request as ready for review February 12, 2025 16:09
@petewall petewall requested a review from rlankfo as a code owner February 12, 2025 16:09
Copy link
Member

@rlankfo rlankfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

run: |
tests=$(ls charts/k8s-monitoring/tests/integration)
tests=$(find . -name values.yaml -exec dirname {} \;)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
tests=$(find . -name values.yaml -exec dirname {} \;)
tests=$(find . -name values.yaml -exec dirname {} +)

🤷

Signed-off-by: Pete Wall <[email protected]>
@petewall petewall merged commit e24ea72 into main Feb 12, 2025
37 checks passed
@petewall petewall deleted the feat/coredns-integration branch February 12, 2025 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v2 -- Please add a coredns cluster metrics feature to satisfy the needs of the CoreDNS integration
2 participants