Clearer dashboard validation #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienduchesne
approved these changes
Feb 6, 2024
pkg/grafana/dashboard-handler.go
Outdated
Comment on lines
92
to
94
| if resource.Name() == "" { | ||
| return fmt.Errorf("name cannot be blank") | ||
| } |
There was a problem hiding this comment.
Isn't that a base condition for all resources?
There was a problem hiding this comment.
Yeah. I did wonder while typing it. Hmm.
There was a problem hiding this comment.
I've updated the PR to do some validation for every resource before calling handler.Validate().
julienduchesne
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now have
Validate()andPrepare(). Validate, well, validates. That is, it either returns nilor an error. Prepare mutates the resource.
This PR moves these two related funcs closer to each other in the code. Also, for dashboards it
refactors the validation logic: