Support output formats #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malcolmholmes
force-pushed
the
malcolmholmes/output-formats
branch
from
ce68230 to
17c63de
Compare
theSuess
reviewed
Jan 19, 2024
theSuess
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Grizzly mostly exports as YAML. It would be useful if the user could
specify the format that they want their content in, e.g. JSON or YAML.
Apart from anything, this would provide a workaround for #301.
Also, the
--only-specparameter allows the user to specify whether to showraw JSON without the envelope. This currently assumes JSON, because, well,
a raw dashboard has always been JSON. This justification makes no actual
sense.
Therefore, this PR adds a
--outputflag to relevant commands, allowing theuser to choose either
yamlorjsonoutputs. These can also be set in thecontext with
grr config set output-format jsonfor example.The
--only-specarg now works with any format (YAML or JSON at present).It can also be set in the context with
grr config set only-spec true.