Skip to content

Commit

Permalink
Update incorrect deprecation message
Browse files Browse the repository at this point in the history
  • Loading branch information
Baarsgaard committed Nov 2, 2024
1 parent e030cee commit b5f819d
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 5 deletions.
4 changes: 3 additions & 1 deletion api/v1beta1/grafanadatasource_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,9 @@ type GrafanaDatasourceInternal struct {

// Deprecated field, it has no effect
OrgID *int64 `json:"orgId,omitempty"`
// Deprecated field, it has no effect

// Whether to enable/disable editing of the datasource in Grafana UI
// +optional
Editable *bool `json:"editable,omitempty"`

// +kubebuilder:validation:Schemaless
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,8 @@ spec:
database:
type: string
editable:
description: Deprecated field, it has no effect
description: Whether to enable/disable editing of the datasource
in Grafana UI
type: boolean
isDefault:
type: boolean
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,8 @@ spec:
database:
type: string
editable:
description: Deprecated field, it has no effect
description: Whether to enable/disable editing of the datasource
in Grafana UI
type: boolean
isDefault:
type: boolean
Expand Down
3 changes: 2 additions & 1 deletion deploy/kustomize/base/crds.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1141,7 +1141,8 @@ spec:
database:
type: string
editable:
description: Deprecated field, it has no effect
description: Whether to enable/disable editing of the datasource
in Grafana UI
type: boolean
isDefault:
type: boolean
Expand Down
2 changes: 1 addition & 1 deletion docs/docs/api.md
Original file line number Diff line number Diff line change
Expand Up @@ -2397,7 +2397,7 @@ GrafanaDatasourceSpec defines the desired state of GrafanaDatasource
<td><b>editable</b></td>
<td>boolean</td>
<td>
Deprecated field, it has no effect<br/>
Whether to enable/disable editing of the datasource in Grafana UI<br/>
</td>
<td>false</td>
</tr><tr>
Expand Down

0 comments on commit b5f819d

Please sign in to comment.