fix(generator): trim group name for CompositeResourceDefinitions #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileymjensen
approved these changes
Dec 19, 2024
nikimanoledaki
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
LGTM 👍
how was commit #2 generated? I couldn't find this in the docs 🤔
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XRD metadata.name consists of
plural+group, for some resources this became longer than 63 characters, which resulted in this error:This PR replaces part of the group name:
s/crossplane.io/netto trim of a few characters.For review: first commit is the manual change, second has the generated files.