First implementation #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nadiamoe
requested review from
a team,
oleiade,
joanlopez,
mstoykov,
codebien,
olegbespalov and
szkiba
and removed request for
a team,
oleiade and
joanlopez
nadiamoe
force-pushed
the
first-implementation
branch
from
50480fe to
03bf325
Compare
codebien
reviewed
Nov 17, 2023
nadiamoe
force-pushed
the
first-implementation
branch
3 times, most recently
from
a8bdc7c to
4e67a84
Compare
|
Sneaking in the comments to mention this tool looks great, and I already would have had a bunch of use cases for it in the past 👍🏻 🚀 |
nadiamoe
force-pushed
the
first-implementation
branch
3 times, most recently
from
cd44cbf to
d2402a2
Compare
nadiamoe
force-pushed
the
first-implementation
branch
from
d2402a2 to
3c3fb19
Compare
nadiamoe
force-pushed
the
first-implementation
branch
from
3c3fb19 to
28a75aa
Compare
codebien
approved these changes
Nov 17, 2023
|
Giving some time in case @olegbespalov or @mstoykov want to comment. Otherwise I'll merge this today EOB 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the first implementation of the
go-depsynctool, made k6-agnostic as a result of the discussion we had in grafana/xk6#72