Skip to content

Update the DisjunctionAsOptions option veneer to work on any argument #731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

K-Phoen
Copy link
Contributor

@K-Phoen K-Phoen commented Jan 27, 2025

In #722, it turns out that we need to apply this veneer on an option that has several arguments. This PR makes the veneer generic-enough to support this use-case

@K-Phoen K-Phoen self-assigned this Jan 27, 2025
@K-Phoen K-Phoen requested a review from a team as a code owner January 27, 2025 14:55
Copy link

Note: the diff show code changes that would be introduced by this PR to the output of the config/foundation_sdk.dev.yaml codegen pipeline (dev version of the Foundation SDK).

🔎 Changes to config/foundation_sdk.dev.yaml

@K-Phoen K-Phoen merged commit 12048cf into main Jan 28, 2025
10 checks passed
@K-Phoen K-Phoen deleted the veneers/generic-DisjunctionAsOptions branch January 28, 2025 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant