Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move k6 E2E tests to Playwright #940

Merged
merged 16 commits into from
Sep 11, 2024
Merged

Move k6 E2E tests to Playwright #940

merged 16 commits into from
Sep 11, 2024

Conversation

adamyeats
Copy link
Contributor

@adamyeats adamyeats commented Aug 13, 2024

This PR replaces the k6 E2E tests with Playwright tests. At the moment, only the config editor is tested. It also updates the Docker Compose config to add the ability to load fixture data, which will come in handy for later integration tests. I've also made other modifications to the other Github Actions, including removing run-ci-cd.yml, as this work is already happening in Drone.

Closes #938

@adamyeats adamyeats added datasource/ClickHouse github_actions Pull requests that update GitHub Actions code effort/small javascript Pull requests that update Javascript code labels Aug 13, 2024
@adamyeats adamyeats self-assigned this Aug 13, 2024
Copy link

github-actions bot commented Aug 13, 2024

Use the following command to run this PR with Docker at http://localhost:3000:

docker run --rm -p 3000:3000 grafana/plugin-builds:eb56d2a81d5e4e7100f1f69f3b0382610ec28c70pre

@adamyeats adamyeats force-pushed the playwright-e2e branch 6 times, most recently from 9a3c160 to 97eab03 Compare August 15, 2024 20:42
@adamyeats adamyeats marked this pull request as ready for review August 15, 2024 20:42
@adamyeats adamyeats requested a review from a team as a code owner August 15, 2024 20:42
alyssabull
alyssabull previously approved these changes Aug 20, 2024
Copy link
Contributor

@alyssabull alyssabull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on this 🚀 I just have question about one of the tests 😄

@adamyeats adamyeats merged commit 691925c into main Sep 11, 2024
16 checks passed
@adamyeats adamyeats deleted the playwright-e2e branch September 11, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datasource/ClickHouse effort/small github_actions Pull requests that update GitHub Actions code javascript Pull requests that update Javascript code
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Remove k6 tests and add plugin-e2e
3 participants