Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

These two regex won't match with the complex column type now. #785

Merged
merged 3 commits into from
Apr 2, 2024

Conversation

haudoing
Copy link
Contributor

@haudoing haudoing commented Apr 1, 2024

@haudoing haudoing requested a review from a team as a code owner April 1, 2024 14:37
@CLAassistant
Copy link

CLAassistant commented Apr 1, 2024

CLA assistant check
All committers have signed the CLA.

@SpencerTorres
Copy link
Collaborator

Thanks for the issue + PR!

I see Nullabe(IP) was also changed, is this covered by a test case? I see theres some other ones in there but not specifically for array nullable.

@haudoing
Copy link
Contributor Author

haudoing commented Apr 1, 2024

Thanks for the issue + PR!

I see Nullabe(IP) was also changed, is this covered by a test case? I see theres some other ones in there but not specifically for array nullable.

Please take a look. I created another testcase to cover column type "Array(Nullable(IPv4))"

@SpencerTorres
Copy link
Collaborator

Just noticed there's IPv4 and IPv6, could you add one more test case for IPv6?

Other than that, the PR looks good. I'll run it locally to verify

@SpencerTorres
Copy link
Collaborator

"Nullable(IP)":              regexp.MustCompile(`Nullable\(IP`),
"Nullable(String)":          regexp.MustCompile(`Nullable\(String`),

It's very interesting that of all of the types there, these are the only two without the ^ prefix. I was worried this was intentional, but after seeing the original commits for String and IP, it seems this was just a small oversight.

I've run the tests and everything looks good. Thanks for the contribution 👍

@bossinc
Copy link
Collaborator

bossinc commented Apr 1, 2024

Thank you @haudoing and @SpencerTorres !

@bossinc bossinc enabled auto-merge (squash) April 2, 2024 16:21
@bossinc bossinc merged commit dcadcf3 into grafana:main Apr 2, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants