fix: Ad-Hoc filters not applied because variables are not recognized by the AST parser #733

SpencerTorres · 2024-02-27T20:32:56Z

Fixes #714

Changes:

Fixed the AST from not recognizing variables such as ${var} ${var.key} and ${var:singlequote}. This was causing Ad-Hoc filters to not be applied, and prevented switching back to the Query Builder.
Switching from SQL Editor back to Query Builder works again. This worked before, but was also broken when using variables. Also it would open an empty query, but now the AST is able to recognize the v4 builder options a little better.
Fixed an issue where an empty database name would put FROM "undefined"."table"
Multi filters (such as ones using WHERE .. IN) now allows for spaces. v3 allowed for a,b,c or a, b, c, v4 had just the first one but now it supports both. You can also include expressions and it works nicely, for example: a, b, toString('c')
Added new unit tests that specifically focus the AST when using macros and variables.
Re-added some tests for the AST + SQL generator. These were removed before because the SQL generator was separated from the utils module, but I've added it back. The original intent of these tests seems to be testing consistency when converting sql->builderOptions->sql.
updated changelog

src/data/ast.test.ts

src/data/ast.ts

src/data/ast.test.ts

src/data/sqlGenerator.ts

asimpson

Seems to work well, thanks! 🏆

SpencerTorres added 3 commits February 27, 2024 15:16

Fix AST not replacing variables

0530a9c

Fix converting from SQL Editor back to Query Builder

7430ed5

changelog

e6b0f36

SpencerTorres requested a review from a team as a code owner February 27, 2024 20:32

SpencerTorres requested review from asimpson, bossinc, aangelisc and adamyeats February 27, 2024 20:32