Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI/CD: add basic linting and spell check #728

Merged
merged 3 commits into from
Feb 22, 2024
Merged

CI/CD: add basic linting and spell check #728

merged 3 commits into from
Feb 22, 2024

Conversation

asimpson
Copy link
Contributor

@asimpson asimpson commented Feb 22, 2024 •
edited
Loading

Our CI/CD doesn't run automatically for external contributions anymore. This leads to unnecessary back and forth for issues like linter errors or mispellings. This will hopefully surface these issues earlier.

@asimpson asimpson requested a review from a team as a code owner February 22, 2024 17:40
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 22, 2024 •
edited
Loading

Use the following command to run this PR with Docker at http://localhost:3000:

docker run --rm -p 3000:3000 grafana/plugin-builds:784833b8e3531e1bea94f67ecd7592cf9d609a75pre

@asimpson asimpson mentioned this pull request Feb 22, 2024
Closed
@asimpson asimpson enabled auto-merge (squash) February 22, 2024 17:48
@asimpson asimpson changed the title add basic linting and spell check CI/CD: add basic linting and spell check Feb 22, 2024
aangelisc
aangelisc approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@aangelisc aangelisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

@asimpson asimpson merged commit 6d65aaf into main Feb 22, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aangelisc aangelisc aangelisc approved these changes

@bossinc bossinc Awaiting requested review from bossinc bossinc is a code owner automatically assigned from grafana/partner-datasources

@adamyeats adamyeats Awaiting requested review from adamyeats adamyeats is a code owner automatically assigned from grafana/partner-datasources

@alyssabull alyssabull Awaiting requested review from alyssabull alyssabull is a code owner automatically assigned from grafana/partner-datasources

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asimpson @aangelisc