Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing bench github action #1041

Merged
merged 2 commits into from
Nov 1, 2024
Merged

Fix failing bench github action #1041

merged 2 commits into from
Nov 1, 2024

Conversation

jalevin
Copy link
Contributor

@jalevin jalevin commented Nov 1, 2024 •
edited
Loading

  • bump bench version
  • remove default auth variables
  • remove comments
  • fix playwright setup command
  • run bench on PR and Push

@jalevin jalevin requested a review from a team as a code owner November 1, 2024 09:10
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2024 •
edited
Loading

Use the following command to run this PR with Docker at http://localhost:3000:

docker run --rm -p 3000:3000 grafana/plugin-builds:59d5ee0487e397ea35982942055e29f15b83f06cpre

@jalevin @adamyeats
Fix bench workflow
a17249b 
* bump bench version
* remove default auth variables
* remove comments
* fix playwright setup command
@jalevin @adamyeats
run on pr
59d5ee0
@adamyeats adamyeats force-pushed the jalevin/fix_bench_workflow branch from 6231baf to 59d5ee0 Compare November 1, 2024 23:33
@adamyeats
Copy link
Contributor

Thanks @jalevin ! 🚀

@adamyeats adamyeats enabled auto-merge (squash) November 1, 2024 23:53
@adamyeats adamyeats merged commit 9ecb401 into main Nov 1, 2024
17 checks passed
@adamyeats adamyeats deleted the jalevin/fix_bench_workflow branch November 1, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SpencerTorres SpencerTorres SpencerTorres left review comments

@adamyeats adamyeats adamyeats approved these changes

@bossinc bossinc Awaiting requested review from bossinc bossinc is a code owner automatically assigned from grafana/partner-datasources

@aangelisc aangelisc Awaiting requested review from aangelisc aangelisc is a code owner automatically assigned from grafana/partner-datasources

@katebrenner katebrenner Awaiting requested review from katebrenner katebrenner is a code owner automatically assigned from grafana/partner-datasources

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jalevin @adamyeats @SpencerTorres