Skip to content

Added shift+enter to run query in raw query editor #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jan 27, 2025
Merged

Added shift+enter to run query in raw query editor #971

merged 12 commits into from
Jan 27, 2025

Conversation

nadav-dav
Copy link
Contributor

@nadav-dav nadav-dav commented Jul 31, 2024 •
edited
Loading

Added shift+enter to run query in raw query editor :)

@nadav-dav nadav-dav requested a review from a team as a code owner July 31, 2024 09:02
@CLAassistant
Copy link

CLAassistant commented Jul 31, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@nadav-dav
Copy link
Contributor Author

Hey guys! :) any news about this?

@aangelisc
Copy link
Contributor

Hey @nadav-dav - apologies for the delay, there were some unexpected side-effects that we're looking at before we can give a full review here 😊 thank you for the contribution and for checking in!

@nadav-dav
Copy link
Contributor Author

Any update?

aangelisc
aangelisc reviewed Oct 31, 2024
View reviewed changes
aangelisc
aangelisc reviewed Oct 31, 2024
View reviewed changes
aangelisc
aangelisc requested changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@aangelisc aangelisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nadav-dav, apologies for the delay in reviewing this. I've suggested some changes as the current implementation has some lint issues.

@nadav-dav nadav-dav requested a review from aangelisc December 25, 2024 07:38
adamyeats
adamyeats previously requested changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@adamyeats adamyeats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nadav-dav It looks like there are still some outstanding pipeline failures on this PR, could you take a look when you have time? 🙏

@aangelisc aangelisc requested a review from adamyeats January 24, 2025 12:22
@nadav-dav
Copy link
Contributor Author

It looks like the steps are failing because of your CI process. I have no control over it

@nadav-dav
Copy link
Contributor Author

I give you the full permission to alter this PR as you see fit to make it run thank you.

alyssajoyner
alyssajoyner approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@alyssajoyner alyssajoyner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition 💯

@aangelisc aangelisc merged commit f5340f3 into grafana:main Jan 27, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aangelisc aangelisc aangelisc approved these changes

@alyssajoyner alyssajoyner alyssajoyner approved these changes

@asimpson asimpson Awaiting requested review from asimpson asimpson is a code owner automatically assigned from grafana/partner-datasources

@bossinc bossinc Awaiting requested review from bossinc bossinc is a code owner automatically assigned from grafana/partner-datasources

@adamyeats adamyeats Awaiting requested review from adamyeats

Assignees
No one assigned
Labels
effort/medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nadav-dav @CLAassistant @aangelisc @adamyeats @alyssajoyner @taleena