-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(pyroscope): mark pyroscope components as GA #904
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Either that. I probably would even argue that the default stability-level for Alloy should be "public-preview"
Let's wait for more approves from @rfratto @tpaschalis @petethepig @Rperry2174 |
I don’t think we should mark components GA because it’s a burden. If the components are stable, are ready for production use, and they won’t have any breaking changes, then they qualify for GA. Are they at that state yet? |
For reference, GA means these two things:
While not documented, we also are trying to aim to release a new major version no more frequently than yearly. I’m comfortable with this PR being merged if these components are ready, but I want to make sure the implications are known first. |
From my perspective it matches all GA criteria. @korniltsev Assuming we are fine with a year without making breaking changes I think this is good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed with the team and also agree that we meet the GA criteria! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the above, I'm on board 👍
PR Description
Dealing with stability-preview is a burden for both internal grafana users and external.
Let's mark
pyroscope.ebpf
,pyroscope.java
,pyroscope.scrape
,pyroscope.write
,discovery.process
as GA.Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist