Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pyroscope): mark pyroscope components as GA #904

Merged
merged 1 commit into from
May 23, 2024
Merged

Conversation

korniltsev
Copy link
Contributor

PR Description

Dealing with stability-preview is a burden for both internal grafana users and external.
Let's mark pyroscope.ebpf, pyroscope.java, pyroscope.scrape, pyroscope.write, discovery.process as GA.

Which issue(s) this PR fixes

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

Copy link
Contributor

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Either that. I probably would even argue that the default stability-level for Alloy should be "public-preview"

@korniltsev
Copy link
Contributor Author

Let's wait for more approves from @rfratto @tpaschalis @petethepig @Rperry2174

@rfratto
Copy link
Member

rfratto commented May 22, 2024

I don’t think we should mark components GA because it’s a burden. If the components are stable, are ready for production use, and they won’t have any breaking changes, then they qualify for GA. Are they at that state yet?

@rfratto
Copy link
Member

rfratto commented May 22, 2024

For reference, GA means these two things:

While not documented, we also are trying to aim to release a new major version no more frequently than yearly.

I’m comfortable with this PR being merged if these components are ready, but I want to make sure the implications are known first.

@petethepig petethepig self-requested a review May 22, 2024 16:52
@petethepig
Copy link
Member

From my perspective it matches all GA criteria.

@korniltsev Assuming we are fine with a year without making breaking changes I think this is good to go.

Copy link

@Rperry2174 Rperry2174 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed with the team and also agree that we meet the GA criteria! 👍

Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the above, I'm on board 👍

@clayton-cornell clayton-cornell added the type/docs Docs Squad label across all Grafana Labs repos label May 22, 2024
@korniltsev korniltsev merged commit db2036b into main May 23, 2024
19 checks passed
@korniltsev korniltsev deleted the pyroscope-ga branch May 23, 2024 01:54
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants