-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to override the cluster headless service port name for Istio support #820
Conversation
This will be needed for an Istio mesh based installation due to this issue with headless services + Istio - https://istio.io/latest/docs/ops/common-problems/network-issues/#503-error-while-accessing-headless-services
What needs to be done to get this over the line? As it's a small change in the Helm Chart. |
@rfratto as you added the label, would you answer the above question for me? |
Thanks for the ping, and sorry this has been sitting around. I'll review this right after sending this comment.
No, sorry; that label is for the maintainers to track what they need to backport after a PR has been merged into main. I wouldn't want contributors to have to go through the effort of backporting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Two small comments but this should be ready to go soon.
Co-authored-by: Robert Fratto <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for working on this!
Includes grafana#820.
This will be needed for an Istio mesh based installation due to this issue with headless services + Istio - https://istio.io/latest/docs/ops/common-problems/network-issues/#503-error-while-accessing-headless-services
PR Description
Which issue(s) this PR fixes
Fixes #800
Notes to the Reviewer
PR Checklist