Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix git lfs issue #2486

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Fix git lfs issue #2486

merged 2 commits into from
Jan 22, 2025

Conversation

rafaelroquetto
Copy link
Contributor

PR Description

Use a vendored version of Beyla that does not rely on git lfs.

Which issue(s) this PR fixes

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@rafaelroquetto rafaelroquetto requested a review from a team as a code owner January 22, 2025 20:23
Copy link
Collaborator

@mattdurham mattdurham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@mattdurham mattdurham enabled auto-merge (squash) January 22, 2025 20:26
@dehaansa dehaansa requested a review from marctc as a code owner January 22, 2025 21:24
@mattdurham mattdurham merged commit 78a9ecb into main Jan 22, 2025
18 checks passed
@mattdurham mattdurham deleted the beyla-1.10 branch January 22, 2025 21:30
Copy link

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checking if 1.9.1 tag is ok.

@@ -56,7 +56,7 @@ require (
github.com/gorilla/mux v1.8.1
github.com/grafana/alloy-remote-config v0.0.9
github.com/grafana/alloy/syntax v0.1.0
github.com/grafana/beyla v0.0.0-20250108110233-3f1b9b55c6dc // custom beyla 1.9.6 branch without breaking replace directives
github.com/grafana/beyla v1.9.1-0.20250122195759-1117708def46 // custom beyla 1.10 branch without git lfs

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why this tag 1.9.1 still?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Custom commits generally pull the last released tag in packages

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought it really should be 1.9.8

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants