-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix git lfs issue #2486
Fix git lfs issue #2486
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just checking if 1.9.1 tag is ok.
@@ -56,7 +56,7 @@ require ( | |||
github.com/gorilla/mux v1.8.1 | |||
github.com/grafana/alloy-remote-config v0.0.9 | |||
github.com/grafana/alloy/syntax v0.1.0 | |||
github.com/grafana/beyla v0.0.0-20250108110233-3f1b9b55c6dc // custom beyla 1.9.6 branch without breaking replace directives | |||
github.com/grafana/beyla v1.9.1-0.20250122195759-1117708def46 // custom beyla 1.10 branch without git lfs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason why this tag 1.9.1 still?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Custom commits generally pull the last released tag in packages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thought it really should be 1.9.8
PR Description
Use a vendored version of Beyla that does not rely on git lfs.
Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist