Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build image to 1.23.3. #2126

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Update build image to 1.23.3. #2126

merged 2 commits into from
Nov 18, 2024

Conversation

mattdurham
Copy link
Collaborator

Update the build image to 1.23

@mattdurham mattdurham marked this pull request as ready for review November 18, 2024 16:15
@mattdurham mattdurham requested a review from a team as a code owner November 18, 2024 16:15
Copy link
Contributor

@wildum wildum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that you also need to update the version in .github/workflows/check-linux-build-image.yml and there is also a comment is tools/build-image/Dockerfile about the version

@mattdurham
Copy link
Collaborator Author

Good call on the workflow, what comment are you referring to?

@wildum
Copy link
Contributor

wildum commented Nov 18, 2024

Good call on the workflow, what comment are you referring to?

https://github.com/grafana/alloy/blob/main/tools/build-image/Dockerfile#L7

@mattdurham mattdurham merged commit 8349b3c into main Nov 18, 2024
19 checks passed
@mattdurham mattdurham deleted the update_go_1_23_buildimage branch November 18, 2024 18:05
vaxvms pushed a commit to vaxvms/alloy that referenced this pull request Nov 20, 2024
* Update build image to 1.23.3.

* Update build image to 1.23.3.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants