Endpoint reload cleanly to prevent duplicate registration #1994
+275
−138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattdurham
changed the title
auto-merge was automatically disabled
October 31, 2024 11:31
Pull request was converted to draft
|
Setting this back to draft, since I am going to move this functionality into a fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with duplicate metrics registration and sending to a closed channel on config changes. By wrapping the mailboxes we can prevent them from explicitly being closed. This can happen in the middle of a scrape where the metrics are still being written to the old endpoint.
This also starts laying the ground work for draining the loops before stopping them to preserve metrics.