Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: finalize asset names for Windows #108

Merged
merged 3 commits into from
Apr 3, 2024
Merged

Conversation

rfratto
Copy link
Member

@rfratto rfratto commented Apr 3, 2024

Finalizes asset names so that all of the following are true:

  • The published binary is named alloy-windows-ARCH.exe
  • The installer is named alloy-installer-windows-ARCH.exe
  • The default config file path (when the installer is used or in Docker) is %PROGRAMFILES%\GrafanaLabs\Alloy\config.alloy
  • The default data storage path (when the installer is used or in Docker) is %ProgramData%\GrafanaLabs\Alloy\data
  • The installed application is named "Alloy" and runs as a service called "Alloy" (both with a capitalized "A")
  • Extra settings for the Windows service are stored in the Registry at HKLM\Software\GrafanaLabs\Alloy

I ran both the Docker container and installer locally to verify all of this information.

rfratto added 3 commits April 3, 2024 13:12
Finalizes asset names so that all of the following are true:

* The published binary is named `alloy-windows-ARCH.exe`
* The installer is named `alloy-installer-windows-ARCH.exe`
* The default config file path (when the installer is used or in Docker)
  is `%PROGRAMFILES%\GrafanaLabs\Alloy\config.alloy`
* The default data storage path (when the installer is used or in
  Docker) is `%ProgramData%\GrafanaLabs\Alloy\data`
* The installed application is named "Alloy" and runs as a service
  called "Alloy" (both with a capitalized "A")
* Extra settings for the Windows service are stored in the Registry at
  `HKLM\Software\GrafanaLabs\Alloy`
@rfratto rfratto requested a review from clayton-cornell as a code owner April 3, 2024 17:33
@rfratto rfratto merged commit ac72ca8 into main Apr 3, 2024
9 checks passed
@rfratto rfratto deleted the finalize-asset-names-windows branch April 3, 2024 17:38
@rfratto rfratto added the backport-to-agent:no PR should NOT be backported to the agent repo. label Apr 23, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport-to-agent:no PR should NOT be backported to the agent repo. frozen-due-to-age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant