Skip to content

Commit

Permalink
Fixes from review
Browse files Browse the repository at this point in the history
  • Loading branch information
clayton-cornell committed Apr 2, 2024
1 parent 40089ba commit 1783f0b
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
10 changes: 5 additions & 5 deletions docs/sources/tasks/migrate/from-operator.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ weight: 320
You can migrate from Grafana Agent Operator to {{< param "PRODUCT_NAME" >}}.

- The Monitor types (`PodMonitor`, `ServiceMonitor`, `Probe`, and `PodLogs`) are all supported natively by {{< param "PRODUCT_NAME" >}}.
- The parts of the Operator that deploy the {{< param "PRODUCT_NAME" >}} itself (`GrafanaAgent`, `MetricsInstance`, and `LogsInstance` CRDs) are deprecated.
- The parts of the Grafana Agent Operator that deploy the Grafana Agent itself (`GrafanaAgent`, `MetricsInstance`, and `LogsInstance` CRDs) are deprecated.

## Deploy {{% param "PRODUCT_NAME" %}} with Helm

Expand Down Expand Up @@ -50,7 +50,7 @@ You can migrate from Grafana Agent Operator to {{< param "PRODUCT_NAME" >}}.
1. Create a Helm release. You can name the release anything you like. The following command installs a release called `alloy-metrics` in the `monitoring` namespace.

```shell
helm upgrade alloy-metrics grafana/alloy -i -n monitoring -f values.yaml --set-file alloy.configMap.content=alloy.alloy
helm upgrade alloy-metrics grafana/alloy -i -n monitoring -f values.yaml --set-file alloy.configMap.content=config.alloy
```

This command uses the `--set-file` flag to pass the configuration file as a Helm value so that you can continue to edit it as a regular {{< param "PRODUCT_NAME" >}} configuration file.
Expand All @@ -59,7 +59,7 @@ You can migrate from Grafana Agent Operator to {{< param "PRODUCT_NAME" >}}.

A `MetricsInstance` resource primarily defines:

- The remote endpoints {{< param "PRODUCT_NAME" >}} should send metrics to.
- The remote endpoints Grafana Agent should send metrics to.
- The `PodMonitor`, `ServiceMonitor`, and `Probe` resources this {{< param "PRODUCT_NAME" >}} should discover.

You can use these functions in {{< param "PRODUCT_NAME" >}} with the `prometheus.remote_write`, `prometheus.operator.podmonitors`, `prometheus.operator.servicemonitors`, and `prometheus.operator.probes` components respectively.
Expand Down Expand Up @@ -127,7 +127,7 @@ Our current recommendation is to create an additional DaemonSet deployment of {{
> still considered experimental, but if you would like to try them, see the documentation for [loki.source.kubernetes][] and
> [loki.source.podlogs][].

These values are close to what the Operator currently deploys for logs:
These values are close to what the Grafana Agent Operator deploys for logs:

```yaml
alloy:
Expand Down Expand Up @@ -268,7 +268,7 @@ The logging subsystem is very powerful and has many options for processing logs.
## Integrations

The `Integration` CRD isn't supported with {{< param "PRODUCT_NAME" >}}.
However, all static mode integrations have an equivalent component in the [`prometheus.exporter`][prometheus.exporter] namespace.
However, all Grafana Agent Static integrations have an equivalent component in the [`prometheus.exporter`][prometheus.exporter] namespace.
The [reference documentation][component documentation] should help convert those integrations to their {{< param "PRODUCT_NAME" >}} equivalent.

<!-- ToDo: Validate path -->
Expand Down
2 changes: 1 addition & 1 deletion docs/sources/tasks/migrate/from-static.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ This conversion will enable you to take full advantage of the many additional fe
Replace the following:

* _`<INPUT_CONFIG_PATH>`_: The full path to the Grafana Agent Static configuration.
* _`<OUTPUT_CONFIG_PATH>_`: The full path to output the {{< param "PRODUCT_NAME" >}} configuration.
* _`<OUTPUT_CONFIG_PATH>`_: The full path to output the {{< param "PRODUCT_NAME" >}} configuration.

1. [Run][run alloy] {{< param "PRODUCT_NAME" >}} using the new {{< param "PRODUCT_NAME" >}} configuration from _`<OUTPUT_CONFIG_PATH>`_:

Expand Down

0 comments on commit 1783f0b

Please sign in to comment.