Allow using library as a local dependency #60
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, thanks for this great library!
I've had some trouble integrating it into a larger project, as the install package was disabled and the
-WError
flag set in the original CMakeLists prevented me from building it due to an unused function.This PR cleans up the CMakeLists and isolates the tests and warnings from the main project. Additionally, it uses PackageProject.cmake to create a proper installable target without much boilerplate. Tests now run in GitHub workflows (Unix, Mac and Windows) and the install itself is tested as well. To build and run the tests, you can now use the tests subdirectory directly.
cmake -Stest -Bbuild cmake --build build cmake --build build --target test
The changes now allow easy integration into external projects. E.g. you can now easily use my fork of CrossGuid through the CPM.cmake package manager:
Let me know if these changes are interesting for you, then I could also update the Readme and add additional tests for iOS and Android.
Fixes #48