Pass idea.properties to studio #507
Conversation
| import java.util.Map; | ||
| import java.util.Set; | ||
| import java.util.TreeSet; | ||
| import java.util.*; |
There was a problem hiding this comment.
I'm personally don't like star imports, but it seems project is using it
There was a problem hiding this comment.
I think we just don't have that strict IDE configuration for this project
| def vmOptions = ideaPropertiesFile.readLines() | ||
| vmOptions.contains("foo=true") |
There was a problem hiding this comment.
💅
| def vmOptions = ideaPropertiesFile.readLines() | |
| vmOptions.contains("foo=true") | |
| def ideaProperties = ideaPropertiesFile.readLines() | |
| ideaProperties.contains("foo=true") |
| @@ -64,6 +71,24 @@ private void logLauncherConfiguration(List<String> commandLine) { | |||
| System.out.printf("* Using command line: %s%n%n", String.join(" ", commandLine)); | |||
| } | |||
|
|
|||
| private Map<String, String> writeIdeaProperties() { | |||
| if (!studioSandbox.getConfigDir().isPresent()) { | |||
There was a problem hiding this comment.
❌ I think we can just create this file also in thestudioSandbox.getJvmArgsDir() so we can set idea.properties even if config dir is not present. jvmArgsDir is just some temp folder that we currently use only for idea.vmoptions.
🤔 We could then maybe also merge writeAdditionalJvmArgs and writeIdeaProperties methods.
💅 Maybe it would be worth also renaming jvmArgsDir to something else after that
| @@ -95,6 +89,7 @@ class ScenarioLoader { | |||
| private static final String TOOLING_API = "tooling-api"; | |||
| private static final String ANDROID_STUDIO_SYNC = "android-studio-sync"; | |||
| private static final String ANDROID_STUDIO_JVM_ARGS = "studio-jvm-args"; | |||
| private static final String ANDROID_STUDIO_IDEA_PROPERTIES = "idea-properties"; | |||
There was a problem hiding this comment.
💅 Could we also update an example in README.md and add also a comment what it does.
It might help if we just add example with the configuration we will use (is it gradle.tooling.models.parallel.fetch=true?). It will then be easy to copy/paste configuration when we will need it :)
| .put("STUDIO_PROPERTIES", ideaProperties.toString()) | ||
| .put("IDEA_PROPERTIES", ideaProperties.toString()) |
There was a problem hiding this comment.
❌ I didn't notice before, but we should pass path to a file here, see this change:
| .put("STUDIO_PROPERTIES", ideaProperties.toString()) | |
| .put("IDEA_PROPERTIES", ideaProperties.toString()) | |
| .put("STUDIO_PROPERTIES", ideaPropertiesFile.toString()) | |
| .put("IDEA_PROPERTIES", ideaPropertiesFile.toString()) |
Signed-off-by: Sergey Opivalov <[email protected]>
Signed-off-by: Sergey Opivalov <[email protected]>
Signed-off-by: Sergey Opivalov <[email protected]>
Signed-off-by: Sergey Opivalov <[email protected]>
Signed-off-by: Sergey Opivalov <[email protected]>
6hundreds
force-pushed
the
6hundreds/pass-idea-registry-entries
branch
from
fb05ec5
to
1ed7b13
Compare
No description provided.