Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convention sample demonstrates disabling test caching by default #1510

Closed

Conversation

erichaagdev
Copy link
Member

Draft because this is not intended to be merged upstream. It only exists so feedback can be provided.

@erichaagdev erichaagdev requested review from etiennestuder, wolfs and a team November 27, 2024 14:33
@erichaagdev erichaagdev self-assigned this Nov 27, 2024
Copy link
Contributor

github-actions bot commented Nov 27, 2024

Job Requested goals Build Tool Version Build Outcome Build Scan®
verification_maven-[object Object] wrapper:wrapper 3.9.9 Build Scan NOT_PUBLISHED
verification_maven-[object Object] clean verify 3.6.3 Build Scan PUBLISHED
Generated by gradle/develocity-actions


static void configureAllProjects(Settings settings, Action<Project> action) {
if (isGradle88OrNewer()) {
settings.getGradle().getLifecycle().beforeProject(action::execute);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wolfs can you confirm this is (currently) the right way to handle Gradle 8.8 and newer and to be IP-compatible?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that is currently the way to go. However, I can't guarantee that the API will stay there.

@erichaagdev erichaagdev force-pushed the erichaagdev/convention-disable-test-caching-by-default branch from 9e8ac76 to 5ee7969 Compare November 27, 2024 14:39
Copy link
Member

@wolfs wolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Gradle changes LGTM!

@erichaagdev erichaagdev closed this Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants