Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make formatting tasks cacheable #95

Closed
wants to merge 3 commits into from
Closed

Make formatting tasks cacheable #95

wants to merge 3 commits into from

Conversation

arunkumar9t2
Copy link
Contributor

@arunkumar9t2 arunkumar9t2 commented Jul 29, 2023 •
edited
Loading

Proposed Changes

Makes all formatting tasks i.e FormatBazelFileTask cacheable i.e they will only rerun if anything changed in the project's generated build scripts.

Work towards #59

Changes

  • Use property and providers instead of dependsOn
  • Using same file as input and output to a task is wonky in gradle, so instead generate raw unformatted file to build and then generate final formatted script in project directoy.
  • Fixed determinism issue in generated Android rules by sorting deps

Screenshot 2023-07-29 at 4 27 41 PM

@arunkumar9t2
Revert temp version
1b7fe0c 
Signed-off-by: arunkumar9t2 <[email protected]>
@arunkumar9t2
Sort tags
83685db 
Signed-off-by: arunkumar9t2 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minkuanlim-grabtaxi minkuanlim-grabtaxi minkuanlim-grabtaxi approved these changes

@vanminh-grabtaxi vanminh-grabtaxi vanminh-grabtaxi approved these changes

@arunsampathkumar-grabtaxi arunsampathkumar-grabtaxi Awaiting requested review from arunsampathkumar-grabtaxi arunsampathkumar-grabtaxi is a code owner

@rifqifahmi-grabtaxi rifqifahmi-grabtaxi Awaiting requested review from rifqifahmi-grabtaxi

@mohammadkahelghi-grabtaxi mohammadkahelghi-grabtaxi Awaiting requested review from mohammadkahelghi-grabtaxi mohammadkahelghi-grabtaxi is a code owner

@stevenchao-grabtaxi stevenchao-grabtaxi Awaiting requested review from stevenchao-grabtaxi stevenchao-grabtaxi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arunkumar9t2 @vanminh-grabtaxi @minkuanlim-grabtaxi