-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Part 3: Per variant maven classpath support #45
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Ignore mkdocks from git See merge request mobile/grazel!79
Update website link in README See merge request mobile/grazel!80
Update documentation See merge request mobile/grazel!90
Release 0.1.0 See merge request mobile/grazel!93
Update docs See merge request mobile/grazel!94
Setup maven central publish configuration See merge request mobile/grazel!92
Update documentation See merge request mobile/grazel!96
Ignore release badge See merge request mobile/grazel!97
Setup codeowners See merge request mobile/grazel!98
Fix licenses See merge request mobile/grazel!99
Add unit tests for sample-lib-flavor 1 and 2 See merge request mobile/grazel!102
Signed-off-by: arunkumar9t2 <[email protected]>
…ndroid_library` resources target (#67) Cleanup hybrid build
Update contraint layout override
* Ensure manifest values `applicationId` is variant specific * Refactor inferring package name for targets * Bump bazel common and buildifier to latest --------- Co-authored-by: Lim Min Kuan <[email protected]>
* Convert version catalog into libs.versions.toml * Fix dependency-catalog.gradle removal from settings.gradle
…zel-common (#73) * Support unified `android_library` and `android_binary` macros from bazel-common Context grab/grab-bazel-common#87 As result of bazel-common's macro handling more specific implementation cases the complexity of grazel managing multiple intermediate targets for kotlin, res value and build config has been reduced/removed. This PR also introduces proper type for representing bazel targets and intermediate extraction data classes `AndroidData` * Fix instrumentation build * Ignore invalid tests
…imports (#74) Make inbuilt repository names no configurable and use constants for imports.
* Remove dead code and refactor DI * Fix inspection suggestions
…f the file strategy for load statements (#77) * Remove dead code and refactor DI * Fix inspection suggestions * Remove duplicate `load` statements and support either inline or top of the file strategy for load statements
Sort load statements
Switch GoogleServiesJsonExtractor to using sourceset's manifestFile instead of javaDirectories to truely support variants
* Ensure generated targets are sorted * Add sample for resource merging * Add sample for overridable resources * Update bazel scripts * Fix typo * Add support for multiple flavored resource dirs
…e times in `WORKSPACE` (#80)
… default. Support `viewbinding`. (#84) Since `bazel-common` is by default used for all targets, remove databinding from migration criteria check. Signed-off-by: arun.sampathkumar <[email protected]>
…to bazel command (#85)
arunkumar9t2
force-pushed
the
refactor-version-handling-2
branch
from
June 17, 2023 21:26
88d42a6
to
547063f
Compare
…#87) * Add config flag to exclude credentials for maven install repositories * Change config flag for credentials to a more descriptive name (includeCredentials)
arunkumar9t2
force-pushed
the
refactor-version-handling-2
branch
from
June 19, 2023 10:13
547063f
to
1853d44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Succeeded by #89
Proposed Changes
Continuing from #44 this change further implements generating multiple
maven_install
s inWORKSPACE
byintroducing new. Done in #57Variant<T>
suite of classesVariant
is a new abstraction to represent both Android and Jvm variants and currently abstractsConfiguration
parsing and supports largely moving away fromConfigurationDataSource
implementation earlier. The newVariant
APIs currently answers the following questions:project
?VariantBuilder
helps to answer this information by returning set ofVaraint<*>
debugImplementation('com.x:y-debug)
will map todebug_maven@//com_x
with alias toy-debug
.In a later stage, we can extend
Variant<T>
to further represent source set and other information needed for migration. Earlier non flavored migration assumption made #30 difficult, this new structure should largely simplify extending Grazel going forward by making it variant first. Eventually a single Gradleproject
instance will be migrated as follows. The new structure also makes it bit easier to write unit tests on each stage (added in this PR).Caveats