Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor jetifier calculation, enable compose in unit tests and declare @UntrackedTask for tasks that don't support up to date checks #114

Closed
wants to merge 1 commit into from
Closed

Refactor jetifier calculation, enable compose in unit tests and declare @UntrackedTask for tasks that don't support up to date checks #114

wants to merge 1 commit into from

Conversation

arunkumar9t2
Copy link
Contributor

@arunkumar9t2 arunkumar9t2 commented Oct 31, 2023 •
edited
Loading

Proposed Changes

  • Using Gradle API to determine if artifact was jetified can be sometimes unreliable since by the time we read it AGP rule would have automatically remapped it. This is addressed by adding jetifierSource that will ensure the source jetifier artifact is always jetified in bazel.
  • Add @UntrackedTask to tasks that are not up-to-date compatible yet.
  • When overrideArtifactVersions is specified ensure they are added to maven_install artifacts
  • When module has compose, ensure unit test also have compose compiler applied.

Testing

  • Existing tests cover refactored functionality.

Issues Fixed

@arunkumar9t2
Refactor jetifier calculation, enable compose in unit tests and decla…
d6cb794 
…re @UntrackedTask for tasks that don't support up to date checks
@arunkumar9t2 arunkumar9t2 marked this pull request as ready for review October 31, 2023 08:34
@arunkumar9t2 arunkumar9t2 changed the title Refactor jetifier calculation, enable compose in unit tests and declare @UntrackedTask for tasks that don't support up to date checks Refactor jetifier calculation, enable compose in unit tests and declare @UntrackedTask for tasks that don't support up to date checks Oct 31, 2023
@arunkumar9t2 arunkumar9t2 mentioned this pull request Nov 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minkuanlim-grabtaxi minkuanlim-grabtaxi minkuanlim-grabtaxi approved these changes

@vanminh-grabtaxi vanminh-grabtaxi Awaiting requested review from vanminh-grabtaxi vanminh-grabtaxi is a code owner

@arunsampathkumar-grabtaxi arunsampathkumar-grabtaxi Awaiting requested review from arunsampathkumar-grabtaxi arunsampathkumar-grabtaxi is a code owner

@mohammadkahelghi-grabtaxi mohammadkahelghi-grabtaxi Awaiting requested review from mohammadkahelghi-grabtaxi mohammadkahelghi-grabtaxi is a code owner

@stevenchao-grabtaxi stevenchao-grabtaxi Awaiting requested review from stevenchao-grabtaxi stevenchao-grabtaxi is a code owner

@arnav-grabtaxi arnav-grabtaxi Awaiting requested review from arnav-grabtaxi arnav-grabtaxi is a code owner

@adarsh-grabtaxi adarsh-grabtaxi Awaiting requested review from adarsh-grabtaxi adarsh-grabtaxi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arunkumar9t2 @minkuanlim-grabtaxi