-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add lint custom rule inspector #174
add lint custom rule inspector #174
Conversation
0ca13e0
to
0a4069a
Compare
rules/android/lint/providers.bzl
Outdated
@@ -11,6 +11,8 @@ AndroidLintNodeInfo = provider( | |||
updated_baseline = "The updated baseline XML", | |||
lint_result_xml = "The lint results XML file", | |||
lint_junit_xml = "Lint result formatted in Junit format", | |||
lint_checks = "Custom Lint Targets", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth making putting this into separate provider? AndroidLintInspectInfo
perhaps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we put a provider in another provder?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah can, accepted pattern. We already do it for passing transitive lint node infos.
tools/lint/src/main/java/com/grab/lint/inspector/ArgumentParser.kt
Outdated
Show resolved
Hide resolved
0a4069a
to
0aaf7aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks
0aaf7aa
to
ea8ac60
Compare
ea8ac60
to
f46361d
Compare
This utility tool helps you inspect which lint rules are applied to each target. Since lint rules can be indirectly applied to targets through AAR dependencies, it's beneficial to know exactly which rules are in effect for each target. This tool generates a JSON file that lists all the rules, provides detailed information about them, and indicates their source.
bazelisk run target_name.lint_inspector