Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add lint custom rule inspector #174

Merged
merged 1 commit into from
May 27, 2024

Conversation

mohammadkahelghi-grabtaxi
Copy link
Collaborator

@mohammadkahelghi-grabtaxi mohammadkahelghi-grabtaxi commented May 24, 2024

This utility tool helps you inspect which lint rules are applied to each target. Since lint rules can be indirectly applied to targets through AAR dependencies, it's beneficial to know exactly which rules are in effect for each target. This tool generates a JSON file that lists all the rules, provides detailed information about them, and indicates their source.

bazelisk run target_name.lint_inspector

@mohammadkahelghi-grabtaxi mohammadkahelghi-grabtaxi force-pushed the add-lint-custom-rules-inspector branch from 0ca13e0 to 0a4069a Compare May 24, 2024 05:16
@@ -11,6 +11,8 @@ AndroidLintNodeInfo = provider(
updated_baseline = "The updated baseline XML",
lint_result_xml = "The lint results XML file",
lint_junit_xml = "Lint result formatted in Junit format",
lint_checks = "Custom Lint Targets",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth making putting this into separate provider? AndroidLintInspectInfo perhaps?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we put a provider in another provder?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah can, accepted pattern. We already do it for passing transitive lint node infos.

@mohammadkahelghi-grabtaxi mohammadkahelghi-grabtaxi force-pushed the add-lint-custom-rules-inspector branch from 0a4069a to 0aaf7aa Compare May 27, 2024 04:49
Copy link
Contributor

@arunkumar9t2 arunkumar9t2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks

@mohammadkahelghi-grabtaxi mohammadkahelghi-grabtaxi force-pushed the add-lint-custom-rules-inspector branch from 0aaf7aa to ea8ac60 Compare May 27, 2024 05:18
@mohammadkahelghi-grabtaxi mohammadkahelghi-grabtaxi force-pushed the add-lint-custom-rules-inspector branch from ea8ac60 to f46361d Compare May 27, 2024 05:21
@mohammadkahelghi-grabtaxi mohammadkahelghi-grabtaxi merged commit ee08c21 into master May 27, 2024
3 checks passed
@mohammadkahelghi-grabtaxi mohammadkahelghi-grabtaxi deleted the add-lint-custom-rules-inspector branch May 27, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants