Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(seed): seed from json data #1728

Merged
merged 4 commits into from
Jan 29, 2025
Merged

fix(seed): seed from json data #1728

merged 4 commits into from
Jan 29, 2025

Conversation

pyphilia
Copy link
Contributor

@pyphilia pyphilia commented Jan 22, 2025 •
edited
Loading

First version for using the seed in the tests with a succinct format.

I've added a new ItemFactory as the one in sdk clashes a lot with the backend types (dates, discriminated item, etc)

ref #995

@pyphilia pyphilia self-assigned this Jan 22, 2025
@pyphilia pyphilia requested review from spaenleh and MatveyK January 22, 2025 11:20
@pyphilia pyphilia marked this pull request as ready for review January 28, 2025 12:16
spaenleh
spaenleh approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good ! I did not have a super deep look, I think it should be used and adapted if needed, I like how you have decomposed it in smaller chunks. Very nice !

src/services/item/service.test.ts Outdated Show resolved Hide resolved
test/factories/item.factory.ts Outdated Show resolved Hide resolved
test/factories/item.factory.ts Outdated Show resolved Hide resolved
test/mocks/seed.ts Outdated Show resolved Hide resolved
@spaenleh spaenleh changed the title 995 seed from json fix(seed): seed from json data Jan 28, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.4% Duplication on New Code

See analysis details on SonarQube Cloud

@pyphilia pyphilia added this pull request to the merge queue Jan 28, 2025
@pyphilia pyphilia removed this pull request from the merge queue due to a manual request Jan 28, 2025
@pyphilia pyphilia added this pull request to the merge queue Jan 29, 2025
Merged via the queue into main with commit ae674e2 Jan 29, 2025
8 checks passed
@graasper graasper mentioned this pull request Jan 29, 2025
Open
@pyphilia pyphilia deleted the 995-seed-from-json branch January 29, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spaenleh spaenleh spaenleh approved these changes

@MatveyK MatveyK Awaiting requested review from MatveyK

Assignees

@pyphilia pyphilia

Labels
un-released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pyphilia @spaenleh