Skip to content
This repository has been archived by the owner on Jan 23, 2025. It is now read-only.

fix: update crop modal #966

Merged
merged 8 commits into from
Jan 29, 2024
Merged

fix: update crop modal #966

merged 8 commits into from
Jan 29, 2024

Conversation

spaenleh
Copy link
Member

@spaenleh spaenleh commented Jan 23, 2024

TODO: merge UI and QueryClient PRs before !

In this PR:

  • cleanup cy.wait in tests
  • cleanup menuSelector var declaration that could be inlined
  • fix accessible search test flake
  • update crop modal to use newest version of the library and use PNG as the blob format

@spaenleh spaenleh self-assigned this Jan 26, 2024
@spaenleh spaenleh added bug 🪲 Something isn't working improvement labels Jan 26, 2024
@spaenleh spaenleh marked this pull request as ready for review January 29, 2024 07:48
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean up!! 🐸

cypress/e2e/item/home/home.cy.ts Outdated Show resolved Hide resolved
src/components/common/CropModal.tsx Show resolved Hide resolved
src/components/common/CropModal.tsx Outdated Show resolved Hide resolved
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
2.1% Duplication on New Code

See analysis details on SonarCloud

@spaenleh spaenleh merged commit 5b15fb7 into main Jan 29, 2024
4 checks passed
@spaenleh spaenleh deleted the update-react-crop branch January 29, 2024 14:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug 🪲 Something isn't working improvement v2.6.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants