Skip to content
This repository has been archived by the owner on Jan 23, 2025. It is now read-only.

fix(style): improve ThumbnailSettings view #706 #819

Merged
merged 2 commits into from
Oct 11, 2023

Conversation

ReidyT
Copy link
Contributor

@ReidyT ReidyT commented Oct 11, 2023

stack button and image
reduce default image size

stack button and image
reduce default image size
@ReidyT ReidyT requested a review from spaenleh October 11, 2023 06:42
@ReidyT ReidyT self-assigned this Oct 11, 2023
@ReidyT ReidyT linked an issue Oct 11, 2023 that may be closed by this pull request
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your first PR 🎉

Looks good to me, but I think you can remove the useless Grid children.

src/components/item/settings/ThumbnailSetting.tsx Outdated Show resolved Hide resolved
@ReidyT ReidyT requested a review from spaenleh October 11, 2023 08:45
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ReidyT ReidyT merged commit fe828a5 into main Oct 11, 2023
@spaenleh spaenleh deleted the 706-rework-item-thumbnail-dispaly-in-item-settings branch October 20, 2023 08:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rework item thumbnail dispaly in item settings
2 participants