refactor: fix tests

graasp · May 22, 2024 · dec7958 · dec7958
1 parent 28421ef
commit dec7958
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 5 deletions.
diff --git a/cypress/e2e/item/publish/coEditorSettings.cy.ts b/cypress/e2e/item/publish/coEditorSettings.cy.ts
@@ -69,7 +69,7 @@ const item = PackedFolderItemFactory(
   { permission: null, publicTag: { type: ItemTagType.Public } },
 );
 
-describe.only('Co-editor setting permissions', () => {
+describe('Co-editor setting permissions', () => {
   it('User signed out cannot edit co-editor setting', () => {
     cy.setUpApi({
       items: [item],

diff --git a/cypress/support/commands/navigation.ts b/cypress/support/commands/navigation.ts
@@ -18,5 +18,5 @@ Cypress.Commands.add('goToHome', () => {
 });
 
 Cypress.Commands.add('goToItemWithNavigation', (id) => {
-  cy.get(`[href="${buildItemPath(id)}"]`).click();
+  cy.get(`[href^="${buildItemPath(id)}"]`).click();
 });
diff --git a/src/components/common/ShareButton.tsx b/src/components/common/ShareButton.tsx
@@ -1,4 +1,4 @@
-import { Link } from 'react-router-dom';
+import { Link, useSearchParams } from 'react-router-dom';
 
 import { ShareButton as GraaspShareButton } from '@graasp/ui';
 
@@ -16,10 +16,16 @@ type Props = {
 };
 
 const ShareButton = ({ itemId }: Props): JSX.Element => {
+  const [searchParams] = useSearchParams();
   const { t: translateBuilder } = useBuilderTranslation();
 
   return (
-    <Link to={buildItemSharePath(itemId)}>
+    <Link
+      to={{
+        pathname: buildItemSharePath(itemId),
+        search: searchParams.toString(),
+      }}
+    >
       <GraaspShareButton
         tooltip={translateBuilder(BUILDER.SHARE_ITEM_BUTTON)}
         ariaLabel={translateBuilder(BUILDER.SHARE_ITEM_BUTTON)}

diff --git a/src/components/layout/Navigation.tsx b/src/components/layout/Navigation.tsx
@@ -56,7 +56,7 @@ const Navigator = (): JSX.Element | null => {
 
     return (
       <>
-        <Link to={HOME_PATH}>
+        <Link to={{ pathname: HOME_PATH, search: searchParams.toString() }}>
           <IconButton id={NAVIGATION_HOME_ID}>
             <Home />
           </IconButton>