Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

insecure ssl support for client #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

insecure ssl support for client #13

wants to merge 1 commit into from

Conversation

gothe92
Copy link

@gothe92 gothe92 commented Feb 22, 2017

Client example:

wstr := transport.GetDefaultWebsocketTransport()
tr.InsecureTls = true
c, err := gosocketio.Dial(
	gosocketio.GetUrl("localhost", 3000, true),
	wstr)

dcormier
dcormier reviewed May 4, 2017
View reviewed changes
transport/websocket.go
@@ -87,11 +88,13 @@ type WebsocketTransport struct {
ReceiveTimeout time.Duration
SendTimeout time.Duration

InsecureTls bool
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initialisms should be capitalized.

@jeanlucmongrain
Copy link

@gothe92 this guy and/or this repository is dead
can you please create your pull request here: https://github.com/gsocket-io/golang-socketio ?
I will maintains this repo in this other generic organization

once it's merged I will rewrite imports

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcormier dcormier dcormier left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gothe92 @jeanlucmongrain @dcormier